Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass 'token' as an HTTP Authorization header #148

Merged
merged 1 commit into from
Jan 21, 2023

Conversation

kohbis
Copy link
Owner

@kohbis kohbis commented Jan 21, 2023

Fix #146

https://api.slack.com/methods/conversations.list

Authentication token bearing required scopes. Tokens should be passed as an HTTP Authorization header or alternatively, as a POST parameter.

  • It looks like the old token can also be passed as a query parameter.
    • Fix it because it's not safe.

@kohbis kohbis self-assigned this Jan 21, 2023
@kohbis kohbis added the bug Something isn't working label Jan 21, 2023
@kohbis kohbis merged commit c7ef074 into main Jan 21, 2023
@kohbis kohbis deleted the token-into-http-header branch January 21, 2023 15:46
@kohbis kohbis mentioned this pull request Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid_auth
1 participant